Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(pd): update pd master required context #1048

Conversation

purelind
Copy link
Contributor

Update pd master required context. releate to tikv/pd#7991.

Signed-off-by: purelind <purelind@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo April 15, 2024 08:49
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2024
@purelind
Copy link
Contributor Author

/hold

wait for tikv/pd#7991 to complete review.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
Comment on lines 1312 to 1319
required-contexts:
- "statics"
- "chunks (1, Unit Test)"
- "chunks (2, Tools Test)"
- "chunks (3, Client Integration Test)"
- "chunks (4, TSO Integration Test)"
- "chunks (5, MicroService Integration Test)"
- "tso-function-test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can write it like tidb to keep simple.

@wuhuizuo
Copy link
Contributor

/lgtm
/approve

prow/config/config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Hu# <ihusharp@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the lgtm label May 17, 2024
prow/config/config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Hu# <ihusharp@gmail.com>
@HuSharp
Copy link
Contributor

HuSharp commented May 17, 2024

/lgtm

Copy link

ti-chi-bot bot commented May 17, 2024

@HuSharp: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@purelind
Copy link
Contributor Author

/cc @wuhuizuo

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo May 17, 2024 06:34
@wuhuizuo
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label May 17, 2024
Copy link

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-15 09:05:36.250451332 +0000 UTC m=+242555.361497779: ☑️ agreed by wuhuizuo.
  • 2024-05-17 06:25:43.770505041 +0000 UTC m=+1807297.527640613: ✖️🔁 reset by purelind.
  • 2024-05-17 06:34:56.219120872 +0000 UTC m=+1807849.976256446: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot merged commit 3eaeadf into ti-community-infra:main May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants